perf: improve playground Lighthouse loading#615
Open
Christayc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #216
Summary
This PR makes
/playground/a lightweight static launcher and moves the full Docusaurus/GraphiQL app to/playground/app/.Changes:
/playgroundroute withstatic/playground/index.html?u=deep links by redirecting/playground/?u=...to/playground/app/?u=...src/pages/playground/app.tsx@graphiql/create-fetcher, toolkit types, cookie-aware storage, and GraphiQL CSS imports intoGraphiQLPanelAnnouncementimport from the playground index moduleValidation
npm cipassednpm run buildpassed and generated static files inbuildgit diff --checkpassedbuild/playground/index.html: it is 4773 bytes, contains no Docusaurus JS bundle references, and only includes the endpoint form plus the small?u=redirect scriptbuild/playground/app/index.htmlis generated for the full React playground routePlayground.tsxno longer statically importsgraphiql,@graphiql/create-fetcher,@graphiql/toolkit, or GraphiQL CSSnpm run typecheckstill fails on existing unrelated repo issues inpublish-externalsand Algolia/DocSearch theme types, but it reports no errors fromsrc/components/playground.I could not run Lighthouse locally in this environment because Chrome/Edge were not available in
PATHandnpx lighthousetimed out while resolving.