Skip to content

Conversation

@thecrypticace
Copy link
Contributor

Fixes #19463

@thecrypticace thecrypticace requested a review from a team as a code owner December 19, 2025 01:39
@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Walkthrough

A changelog entry was added documenting the detection of utilities containing capital letters followed by numbers (PR #19465). In the NamedUtilityMachine parsing logic, AlphaUpper was added as a valid preceding classification for Number tokens, allowing capital letters to precede numeric sequences (e.g., text-titleV1-strong). The test suite was updated to include a corresponding test case validating the new extraction behavior.

Pre-merge checks

✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: detecting utilities with capital letters followed by numbers in utility names.
Description check ✅ Passed The description references the fixed issue (#19463), which is relevant to the changeset addressing mixed-case parent keys in nested color objects.
Linked Issues check ✅ Passed The code changes in the NamedUtilityMachine parser update the logic to accept capital letters preceding numbers in utility names, directly addressing issue #19463's requirement to support mixed-case keys like iosV3.
Out of Scope Changes check ✅ Passed All changes are focused on the named utility machine parsing logic and corresponding test cases, directly scoped to fixing the capital letter + number detection issue.

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbd26b9 and ae44cbf.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • crates/oxide/src/extractor/named_utility_machine.rs (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Linux / vite
  • GitHub Check: Linux / upgrade
  • GitHub Check: Linux / cli
  • GitHub Check: Linux / postcss
  • GitHub Check: Linux
🔇 Additional comments (2)
CHANGELOG.md (1)

15-15: Changelog entry correctly documents the extractor fix

The new “Detect utilities when containing capital letters followed by numbers” bullet is accurate, scoped, and consistent with existing changelog style. No changes needed.

crates/oxide/src/extractor/named_utility_machine.rs (1)

279-304: Allow numbers after uppercase letters to support mixed‑case segments

Including Class::AlphaUpper in the valid predecessors for Class::Number fixes parsing of sequences like V1 in text-titleV1-strong while keeping the rest of the numeric rules intact (next-char checks unchanged, start state still disallows uppercase-only utilities). The added test case for text-titleV1-strong correctly exercises this path and guards against regressions. No further changes needed.

Also applies to: 427-430


Comment @coderabbitai help to get the list of available commands and usage tips.

@thecrypticace thecrypticace merged commit 543da3f into main Dec 19, 2025
7 checks passed
@thecrypticace thecrypticace deleted the fix/issue-19463 branch December 19, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested color objects with mixed-case parent keys don't generate utilities in v4

3 participants