Skip to content

Add clean DINOv2 anomaly detection script#6

Open
Eranlaz wants to merge 1 commit into
mainfrom
dinov2_clean_pipeline
Open

Add clean DINOv2 anomaly detection script#6
Eranlaz wants to merge 1 commit into
mainfrom
dinov2_clean_pipeline

Conversation

@Eranlaz

@Eranlaz Eranlaz commented May 18, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@Eranlaz Eranlaz requested review from SaritMeshesha and taimax13 May 18, 2025 18:50
@Eranlaz Eranlaz self-assigned this May 18, 2025
Comment thread sar‑anomaly_detection_dino_v2.py Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cfg = processor.size
shape = processor.size

Comment thread sar‑anomaly_detection_dino_v2.py Outdated
Comment on lines 99 to 100

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why random subset rather than PCA etc.?

Comment thread sar‑anomaly_detection_dino_v2.py Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inverse covariance is used due to numerical algebra. It has nothing to do with weights (which could be added as well).

Comment thread sar‑anomaly_detection_dino_v2.py Outdated
Comment on lines 136 to 142

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use a Jupyter notebook?

Comment thread sar‑anomaly_detection_dino_v2.py Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not fine-tune DINO on the training set?

@chkp-talexm

Copy link
Copy Markdown
Contributor

@Eranlaz can you please re-direct pr to develop and pull from there as well please, I can not edit it on your pr :)

@taimax13

taimax13 commented Aug 3, 2025

Copy link
Copy Markdown
Owner

@Eranlaz where are you on this pr - ? can you accept - reject suggestions and merge it please :)

@InonS

InonS commented Aug 3, 2025

Copy link
Copy Markdown
Collaborator

@Eranlaz @taimax13 @chkp-talexm I reviewed and added 5 comments, some of them substantial, but didn't see any response.

@InonS

InonS commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

@Eranlaz is this PR still relevant, after #12 ? If not, perhaps it should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants