Skip to content

feat(platform): provider detail drawer + api-key suffix masking #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Israeltheminer merged 5 commits into from
May 22, 2026
Merged

feat(platform): provider detail drawer + api-key suffix masking #1729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1012ce
feat(platform): provider detail drawer + api-key suffix masking
Israeltheminer May 21, 2026
ac4d901
fix(platform): resolve CI failures on provider drawer PR
Israeltheminer May 21, 2026
74c4fd2
Merge branch 'main' into feat/platform-provider-detail-drawer
Israeltheminer May 22, 2026
ad82abe
revert: drop local-scratch edits to examples/providers
Israeltheminer May 22, 2026
2085b48
fix(platform): apply CodeRabbit review feedback on provider drawer
Israeltheminer May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services/platform/app/features/settings/api-keys/components/api-key-revoke-dialog.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function makeApiKey(overrides: Partial<ApiKey> = {}): ApiKey {
name: 'Test Key',
start: 'tale_abc',
prefix: 'tale_',
suffix: 'wxyz',
userId: 'user-1',
enabled: true,
expiresAt: null,
Expand Down
1 change: 1 addition & 0 deletions services/platform/app/features/settings/api-keys/components/api-key-row-actions.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function makeApiKey(overrides: Partial<ApiKey> = {}): ApiKey {
name: 'Test Key',
start: 'tale_abc',
prefix: 'tale_',
suffix: 'wxyz',
userId: 'user-1',
enabled: true,
expiresAt: null,
Expand Down
1 change: 1 addition & 0 deletions services/platform/app/features/settings/api-keys/components/api-keys-table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ function makeApiKey(overrides: Partial<ApiKey> = {}): ApiKey {
name: 'Test Key',
start: 'tale_abc',
prefix: 'tale_',
suffix: 'wxyz',
userId: 'user-1',
enabled: true,
expiresAt: null,
Expand Down
21 changes: 16 additions & 5 deletions services/platform/app/features/settings/api-keys/hooks/use-api-keys-table-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,22 @@ export function useApiKeysTableConfig(
{
id: 'key',
header: tSettings('apiKeys.columns.key'),
cell: ({ row }) => (
<Text as="span" variant="muted" className="font-mono text-sm">
{row.original.start || row.original.prefix || '-'}
</Text>
),
cell: ({ row }) => {
const head = row.original.start || row.original.prefix;
const tail = row.original.suffix;
const display = head
? tail
? `${head} … ${tail}`
: head
: tail
? `… ${tail}`
: '-';
return (
<Text as="span" variant="muted" className="font-mono text-sm">
{display}
</Text>
Comment on lines +42 to +54
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Handle suffix-only fallback in key rendering.

If start and prefix are missing but suffix exists, the current branch shows - and hides usable key identity data.

Proposed fix 
-              {head ? (tail ? `${head} … ${tail}` : head) : '-'}
+              {head
+                ? tail
+                  ? `${head} … ${tail}`
+                  : head
+                : tail
+                  ? `… ${tail}`
+                  : '-'}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@services/platform/app/features/settings/api-keys/hooks/use-api-keys-table-config.tsx`
around lines 42 - 47, The rendering currently sets head = row.original.start ||
row.original.prefix and hides the suffix when both start and prefix are missing;
change the fallback so that if head is falsy but row.original.suffix exists we
still render the suffix (e.g., show just the tail or "… {tail}") instead of '-'
— update the component in use-api-keys-table-config.tsx where head and tail are
computed and the JSX return so the conditional becomes: if head show (head +
optional tail), else if tail show tail (or a prefixed ellipsis + tail), else
show '-'. This ensures row.original.suffix is used when start/prefix are absent.

);
},
},
{
id: 'created',
Expand Down
10 changes: 10 additions & 0 deletions services/platform/app/features/settings/api-keys/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ export interface ApiKey {
* Used as fallback when `start` is not available.
*/
prefix: string | null;
/**
* Trailing plaintext characters of the key, captured at creation time
* by an after-hook on `/api-key/create` (the upstream Better Auth
* plugin doesn't know about this column). Rendered alongside `start`
* as `start … suffix` so users can match a row against the key they
* hold. Optional because (a) Better Auth's SDK return type doesn't
* include it and (b) rows created before this feature shipped have no
* value — those render with the prefix only.
*/
suffix?: string | null;
userId?: string;
enabled: boolean | null;
expiresAt: Date | null;
Expand Down
Loading
Loading