Merged
Conversation
Owner
|
How is this different from #271? Plz point me to the specific line. |
Collaborator
Author
Copied from the email: Good question, they are identical materially, except for the parameter name change in the new test (commit 31d872). Due to the name change or lack thereof, 271 does not pass the tests since it is not merged with the latest master. I want to keep 271’s side branch without merging it with the latest CGRA RTL changes to make sure we have a working SV model. 271 is obsolete and can be closed without merging. (Sorry about the duplicate requests. I was not aware of the planned RTL change when I started 271; I would not have opened it otherwise.) |
tancheng
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
tests to the Mesh multi-CGRA suite.