Skip to content

Conversation

@qevolg
Copy link
Contributor

@qevolg qevolg commented Dec 1, 2025

Description

Add TDENGINE_DRIVER environment variable for websocket support

Jira: https://jira.taosdata.com:18080/browse/TS-6188

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link

Summary of Changes

Hello @qevolg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on integrating WebSocket support into the TDengine Python connector. It achieves this by introducing an environment variable that allows users to switch between native and WebSocket drivers. Accompanying this change are minor code cleanups and adjustments to existing tests to ensure compatibility with the new driver mode. The temporary disabling of several test files suggests ongoing work or a specific testing scope for this feature.

Highlights

  • WebSocket Driver Support: Introduced a new environment variable TDENGINE_DRIVER which, when set to 'websocket', enables WebSocket mode for the TDengine driver. This is exposed via a new IS_WS boolean in the taos package.
  • Code Cleanup: Removed unused imports (List, Optional, get_tz) and an unused helper function (_is_not_none) from taos/bind.py, streamlining the codebase.
  • Test Adaptations for WebSocket Mode: Modified test_cinterface.py to conditionally skip test_taos_connect_auth when the WebSocket driver is active, ensuring tests are relevant to the current driver configuration.
  • Test File Disablement: Several test files, specifically test_decode_binary.py, test_stmt.py, and test_stmtV3.py, have been entirely commented out. This suggests a temporary disabling of these tests, possibly for refactoring or to focus testing on other areas.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for a websocket driver, configurable via the TDENGINE_DRIVER environment variable. A new flag IS_WS is added to conditionally execute code based on the selected driver. While this is a good approach, a major concern is that several test files (test_decode_binary.py, test_stmt.py, test_stmtV3.py) have been entirely commented out. This effectively removes a significant portion of the test suite, which can hide regressions and bugs. Instead of commenting out tests, they should be fixed to work with the websocket driver, or explicitly skipped using pytest.mark.skipif with a clear reason. This ensures test coverage is tracked and encourages future fixes.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.31%. Comparing base (1db963d) to head (2630abc).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #375       +/-   ##
===========================================
- Coverage   81.94%   71.31%   -10.64%     
===========================================
  Files          24       24               
  Lines        3644     3639        -5     
===========================================
- Hits         2986     2595      -391     
- Misses        658     1044      +386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants