-
Notifications
You must be signed in to change notification settings - Fork 17
chore: add TDENGINE_DRIVER environment variable for websocket support #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @qevolg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on integrating WebSocket support into the TDengine Python connector. It achieves this by introducing an environment variable that allows users to switch between native and WebSocket drivers. Accompanying this change are minor code cleanups and adjustments to existing tests to ensure compatibility with the new driver mode. The temporary disabling of several test files suggests ongoing work or a specific testing scope for this feature. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for a websocket driver, configurable via the TDENGINE_DRIVER environment variable. A new flag IS_WS is added to conditionally execute code based on the selected driver. While this is a good approach, a major concern is that several test files (test_decode_binary.py, test_stmt.py, test_stmtV3.py) have been entirely commented out. This effectively removes a significant portion of the test suite, which can hide regressions and bugs. Instead of commenting out tests, they should be fixed to work with the websocket driver, or explicitly skipped using pytest.mark.skipif with a clear reason. This ensures test coverage is tracked and encourages future fixes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
===========================================
- Coverage 81.94% 71.31% -10.64%
===========================================
Files 24 24
Lines 3644 3639 -5
===========================================
- Hits 2986 2595 -391
- Misses 658 1044 +386 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Add TDENGINE_DRIVER environment variable for websocket support
Jira: https://jira.taosdata.com:18080/browse/TS-6188
Checklist
Please check the items in the checklist if applicable.