Track the tap::mu kernel: bump submodule, adopt namespace, fix FFT target#11
Merged
Merged
Conversation
Bump the drift-check ref v3 -> v4 and add scripts/tidy.sh (the local clang-tidy gate mirror, now distributed by TapHouse). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
…rget The MuTap kernel migrated its C++ namespace mutap -> tap::mu and, as part of the DspTap extraction, replaced its vendored Ooura FFT target (MuTap::fft) with the shared DspTap real FFT (tap::dsp). This wrapper follows: - Bump the submodules/MuTap pin to the migrated kernel (tap::mu + DspTap). - Rename mutap:: -> tap::mu:: across the Min wrappers (basic_real_fft and the pem_afc/fdkf/lpc types stay reachable under tap::mu via the kernel's shim). The mutap/ include paths are unchanged. - Link the FFT objects (aec, afc) against tap::dsp instead of MuTap::fft. Verified: configure succeeds and the wrappers compile against the bumped kernel. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
tap::mu differs in width from mutap, shifting clang-format's alignment columns. Reformat with the Tap-wide pinned clang-format (v18.1.3). No functional change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the MuTap kernel's migration to
tap::muand its DspTap FFT extraction.Changes
submodules/MuTapto the migrated kernel (tap::mu+ the sharedDspTap FFT).
mutap:: → tap::mu::across the Min wrappers.basic_real_fftandthe
pem_afc/partitioned_fdkf/warped_lpc_predictortypes stayreachable under
tap::muvia the kernel's shim. Themutap/include pathsare unchanged.
MuTap::ffttarget (the vendored Ooura static lib). The FFT-linked objects(aec, afc) now link
tap::dsp.Verification
Configure succeeds and the wrappers compile against the bumped kernel.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
Generated by Claude Code