C++20 everywhere: centralize the standard, drop per-object overrides#12
Merged
Merged
Conversation
Min's posttarget pins each external to C++17. Instead of overriding that per object, the root now re-forces C++20 on every target an object folder creates, right after add_subdirectory — one place. The sweep also cancels min's Apple Catch opt-out (CATCH_CONFIG_NO_CPP17_UNCAUGHT_EXCEPTIONS, which forces the C++20-removed std::uncaught_exception()) on any _test target, so future wrapper tests build at C++20 on macOS too. Remove the now-redundant per-object CXX_STANDARD 20 overrides. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Min's posttarget pins each external to C++17, so today each object's CMakeLists re-overrides
CXX_STANDARDto 20. This centralizes it: the root re-forces C++20 on every target an object folder creates, right afteradd_subdirectory— one place.Changes
add_subdirectory(source/projects/…), sweep itsBUILDSYSTEM_TARGETSto C++20.CXX_STANDARD 20overrides.CATCH_CONFIG_NO_CPP17_UNCAUGHT_EXCEPTIONS, which forces the C++20-removedstd::uncaught_exception()) on any_testtarget — inert here (no wrapper tests today), but keeps the sweep identical to TapTools-Max and future-proofs macOS test builds.Verification
Objects compile under C++20 via the central sweep (confirmed locally). No behavior change — purely how the standard is set.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
Generated by Claude Code