Bump the DspTap pin to 28a34a1 - #13
Merged
Merged
Conversation
Refreshes submodules/dsptap from dfbe18d to 28a34a1, the current DspTap main. This repo was the least stale consumer in the family, one commit behind, and that commit is documentation only -- the shared pull-request template synced from taphouse. No substrate change reaches this repo. Pinned to a commit on DspTap's main rather than to any in-flight branch, per the release flow: consumer pins must reference a tree that stays reachable after branch cleanup. Verified against the substrate discipline this repo depends on -- shared code lands in DspTap first and here second, so a pin bump is the only correct way to pick it up: configure and build clean with zero errors, ctest 58/58 passing in Release, which includes the exhaustive phase sweeps and the pinned-eps cross-validation against SampleRateTap. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JhhQ93r2E1QTnCx46YfX8j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Refreshes
submodules/dsptapfromdfbe18dto28a34a1(current DspTapmain) — a single commit.Why
This repo was the least stale consumer in the family, one commit behind, and that commit is documentation only: the shared pull-request template synced from taphouse. No substrate change reaches this repo.
Bumping anyway because the pin is the mechanism this repo's substrate discipline depends on — shared code lands in DspTap first and here second, so keeping the pin current is how that stays a small, routine step.
Verification
Configure and build clean, zero errors, ctest 58/58 passing in Release — which includes the exhaustive phase sweeps (all 147 and all 160 phases) and the pinned-eps cross-validation against SampleRateTap.
Checked before bumping: across the whole range every change under DspTap's
include/is an addition (9 new headers, none modified or deleted), exported targets are identical at both ends, and there's no consumer-facing CMake change. For this repo the range is a single docs commit, so that analysis is almost redundant — but it's the same check applied uniformly across all four repos in the sweep.Notes for the reviewer
Pinned to a commit on DspTap's
mainrather than any in-flight branch, so the pin stays reachable after branch cleanup — and independent of tap/DspTap#8.Part of a four-repo sweep (RatioTap, SampleRateTap, TapTools, AmbiTap). MuTap is deliberately excluded: 11 commits behind, but its macOS CI is red from tap/MuTap#31 and a dsptap bump is one of that issue's candidate fixes, so it belongs there rather than riding along in a routine refresh.
Nothing here touches the instruction-count ratchet, and the bump changes no code this repo compiles, so no
bench/baselines.jsonre-record should be needed — the CI ratchet is the check on that claim.Generated by Claude Code