feat: fix possible line loss and duplication when file name is changed#1
Merged
oleg-jukovec merged 2 commits intomasterfrom Apr 23, 2026
Merged
Conversation
elhimov
force-pushed
the
elhimov/gh-73-loss-and-duplication-at-log-rotation
branch
2 times, most recently
from
a6bdec5 to
39df56b
Compare
sssciel
approved these changes
Apr 20, 2026
oleg-jukovec
requested changes
Apr 21, 2026
oleg-jukovec
requested changes
Apr 21, 2026
elhimov
force-pushed
the
elhimov/gh-73-loss-and-duplication-at-log-rotation
branch
5 times, most recently
from
feec840 to
baba3a2
Compare
oleg-jukovec
requested changes
Apr 22, 2026
elhimov
force-pushed
the
elhimov/gh-73-loss-and-duplication-at-log-rotation
branch
from
baba3a2 to
ee3e0e6
Compare
elhimov
changed the title
elhimov
force-pushed
the
elhimov/gh-73-loss-and-duplication-at-log-rotation
branch
from
ee3e0e6 to
553d0c8
Compare
oleg-jukovec
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use tail to collect logs (starting from the beginning of the new file), during file renaming (when flush and rename events occur very close to each other), part of the old log file may not be collected (write event -> truncated event), and the new file may be collected twice (truncated (write -> truncated) and delete events occurring simultaneously). Therefore, an issue fix is proposed.
Duplication of nxadm#73