Skip to content

ci: rethinking version check#92

Merged
oleg-jukovec merged 1 commit intomasterfrom
i.ostanevich/hotfix-version-check
Mar 3, 2026
Merged

ci: rethinking version check#92
oleg-jukovec merged 1 commit intomasterfrom
i.ostanevich/hotfix-version-check

Conversation

@Col-Waltz
Copy link
Contributor

@Col-Waltz Col-Waltz commented Mar 2, 2026

Version check makes git clean before work and cleans all
previous rocks installation. The idea is to install needed
packages to the directory where it won't be cleaned by git
and add this directory to the lua path before version check.

Part of #77

@Col-Waltz Col-Waltz added the do not merge Not ready to be merged label Mar 2, 2026
@coveralls
Copy link

coveralls commented Mar 2, 2026

Pull Request Test Coverage Report for Build 22615566680

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 91.277%

Totals Coverage Status
Change from base Build 22580894235: 0.3%
Covered Lines: 1308
Relevant Lines: 1433

💛 - Coveralls

@Col-Waltz Col-Waltz force-pushed the i.ostanevich/hotfix-version-check branch 10 times, most recently from 082bc72 to 839449a Compare March 2, 2026 22:50
@Col-Waltz Col-Waltz removed the do not merge Not ready to be merged label Mar 2, 2026
@Col-Waltz Col-Waltz requested a review from oleg-jukovec March 2, 2026 22:51
@Col-Waltz Col-Waltz force-pushed the i.ostanevich/hotfix-version-check branch from 839449a to 5c26227 Compare March 3, 2026 08:53
Version check makes git clean before work and cleans all
previous rocks installation. The idea is to install needed
packages to the directory where it won't be cleaned by git
and add this directory to the lua path before version check.

Part of #77
@Col-Waltz Col-Waltz force-pushed the i.ostanevich/hotfix-version-check branch from 5c26227 to 4c826ba Compare March 3, 2026 08:56
@Col-Waltz Col-Waltz requested a review from oleg-jukovec March 3, 2026 08:57
@oleg-jukovec oleg-jukovec merged commit a89afbd into master Mar 3, 2026
7 checks passed
@oleg-jukovec oleg-jukovec deleted the i.ostanevich/hotfix-version-check branch March 3, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants