Fix pr num lookup and a couple of other minor issues#82
Merged
Conversation
This was necessary for on site hosted git but now with github migration this is no longer required so aligning it with the github settings route Signed-off-by: banginji <7316646+banginji@users.noreply.github.com>
This was done because a name collision error started showing up with a github related dependency package in the recent version Signed-off-by: banginji <7316646+banginji@users.noreply.github.com>
Signed-off-by: banginji <7316646+banginji@users.noreply.github.com>
1- Modified the graphql lookup to now use the pr_num instead of the head and base refs to make it more stable 2- Updated the pr_num lookup to be of type int instead of a str Signed-off-by: banginji <7316646+banginji@users.noreply.github.com>
Signed-off-by: banginji <7316646+banginji@users.noreply.github.com>
Author
Preview of the log fixBefore After |
Author
Preview of the sha lookup fixBefore Diff SummaryDetected 2 changes to dependencies in Poetry lockfileFrom base
(2 added, 0 removed, 0 updated, 26 not changed) Generated by diff-poetry-lock 1.0.1.dev0 After Diff SummaryDetected 2 changes to dependencies in Poetry lockfileFrom base
(2 added, 0 removed, 0 updated, 26 not changed) Generated by diff-poetry-lock 1.0.1.dev0 |
colindean
approved these changes
Jun 22, 2026
Collaborator
|
Excellent work! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The vela route pr_num lookup was customized when github was hosted on prem but now with the migration to github cloud, the pr_num lookup can be simplified which this pr is for
In addition to that, fixed a couple of minor issues to get the tool working with vela:
Error thrown before renaming: