Add a workflow to run auto updates for pre-commit#678
Merged
Eijebong merged 4 commits intotaskcluster:mainfrom Apr 16, 2025
Merged
Add a workflow to run auto updates for pre-commit#678Eijebong merged 4 commits intotaskcluster:mainfrom
Eijebong merged 4 commits intotaskcluster:mainfrom
Conversation
This replaces the pre-commit.ci app's autoupdate. The one caveat with this is that it doesn't check for PRs that are already opened on that branch. I did that to keep it as simple as possible. It's not a real issue as github will detect that and close the previous PR and then open a new one but it might be a bit spammy if we don't merge those PRs
Contributor
Author
|
example of it working. I have this repo where I ran the job on push instead of cron. |
ahal
reviewed
Apr 11, 2025
Collaborator
|
I somewhat think it wouldn't be much harder to do this as a Taskcluster cron, but also that it's not worth switching now |
Contributor
Author
The advantage of this is that we don't have to worry about the token as github provides it for us in the workflow. |
Collaborator
True! One trick we could use is that because |
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 14, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Contributor
Author
I think it's something I have mentioned previously at a community meeting. We already have a way of creating comments through said app, it would be nice to expand on that capability |
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 14, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 16, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678
Eijebong
added a commit
to Eijebong/mozilla-taskgraph
that referenced
this pull request
Apr 16, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678 Also ran uv sync to make pre-commit happy
ahal
approved these changes
Apr 16, 2025
ahal
pushed a commit
to mozilla-releng/mozilla-taskgraph
that referenced
this pull request
Apr 21, 2025
Since we're using the uv hook, pre-commit requires the internet to work properly which the pre-commit.ci app ran jobs don't have access to. These two workflows are meant to replace the app entirely by doing both checking on PRs/main and auto updates. It means that we do lose the autofix feature, but it's that or throwing away the uv-lock hook. Original work done in taskcluster/taskgraph#677 and taskcluster/taskgraph#678 Also ran uv sync to make pre-commit happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the pre-commit.ci app's autoupdate.
The one caveat with this is that it doesn't check for PRs that are already opened on that branch. I did that to keep it as simple as possible. It's not a real issue as github will detect that and close the previous PR and then open a new one but it might be a bit spammy if we don't merge those PRs