feat(load-task): add a --user flag to specify which user to run as#685
Merged
ahal merged 1 commit intotaskcluster:mainfrom May 15, 2025
Merged
feat(load-task): add a --user flag to specify which user to run as#685ahal merged 1 commit intotaskcluster:mainfrom
ahal merged 1 commit intotaskcluster:mainfrom
Conversation
ahal
force-pushed
the
ahal/push-pwrnwnyzlvwq
branch
from
888d92b to
a821cc1
Compare
ahal
force-pushed
the
ahal/push-pwrnwnyzlvwq
branch
from
a821cc1 to
e02c251
Compare
hneiva
approved these changes
May 14, 2025
|
|
||
| def load_task(task_id, remove=True): | ||
| def load_task(task_id, remove=True, user=None): | ||
| user = user or "worker" |
Contributor
There was a problem hiding this comment.
Why not just user="worker" in the arguments?
Collaborator
Author
There was a problem hiding this comment.
That way the caller can explicitly pass in None and it'll still work. E.g, they can do load_task(..., args.get("user")) or similar.
Just a little habit I picked up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.