Remove support for docker-in-docker, privileged and loopback-audio do…#753
Open
jcristau wants to merge 1 commit intotaskcluster:mainfrom
Open
Remove support for docker-in-docker, privileged and loopback-audio do…#753jcristau wants to merge 1 commit intotaskcluster:mainfrom
jcristau wants to merge 1 commit intotaskcluster:mainfrom
Conversation
…cker-worker features As far as I know they're unused at this point. In addition: - docker-in-docker involves talking to the docker daemon on the host, which has proven problematic as it bakes in dependencies on the docker daemon's version. It's also dubious from a security perspective, and as far as I can tell doesn't work in generic-worker/d2g (it doesn't have a proxy to only allow "safe" commands) - privileged is inherently problematic as it makes the task root-equivalent on the worker - loopback audio these days is achieved with dummy devices at the pulseaudio or pipewire level, not at the kernel level
jcristau
added
the
BREAKING CHANGE
bhearsum
approved these changes
Sep 2, 2025
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
These all look unused in Gecko (and hopefully elsewhere as well?). Should be safe to remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cker-worker features
As far as I know they're unused at this point. In addition: