Bug 1996563 - Generate perfherder_data artifacts for jobs running fetch-content#855
Merged
bhearsum merged 1 commit intotaskcluster:mainfrom Nov 13, 2025
Merged
Conversation
06d83f1 to
af79673
Compare
Contributor
Author
|
I modified the code directly in mozilla-central to test it. Here is the CI test I ran. [0] [0] |
bhearsum
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some workers run in dynamically generated working directories (e.g.,
D:\task_17612\or/home/cltbld/tasks/task_17612/), which means the upload path isn’t always static.Previously, we relied on
UPLOAD_DIRwhen generating the artifact, but not all jobs expose this environment variable, which caused inconsistencies.To fix this, we added a new environment variable,
PERFHERDER_FETCH_CONTENT_JSON_PATH[0]. It gives us a clear and reliable file path, so we can always generate theperfherder-data-fetch-content.jsonartifact correctly on any worker.[0]
Related patch (mozilla-central): https://phabricator.services.mozilla.com/D270831
Bugzilla link: https://bugzilla.mozilla.org/show_bug.cgi?id=1996563