Skip to content

Add per-task ack type support#636

Merged
s3rius merged 1 commit into
taskiq-python:masterfrom
vvanglro:feature/per-task-ack-type
Jul 8, 2026
Merged

Add per-task ack type support#636
s3rius merged 1 commit into
taskiq-python:masterfrom
vvanglro:feature/per-task-ack-type

Conversation

@vvanglro

@vvanglro vvanglro commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add per-task ack_type support via task labels, overriding worker-level --ack-type when present.
  • Support both string values and AcknowledgeType enum values for task-level ack configuration.
  • Export AcknowledgeType from taskiq and document the new per-task usage.

Related discussion: https://github.com/orgs/taskiq-python/discussions/635

Testing

  • uv run pytest tests/receiver/test_receiver.py -q
  • uv run ruff check taskiq/acks.py taskiq/receiver/receiver.py taskiq/__init__.py tests/receiver/test_receiver.py
  • uv run mypy taskiq
  • uv run pytest -q -x --ignore=tests/opentelemetry
  • uv run pytest tests/opentelemetry -q

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (9f8db96) to head (2bdde8f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   79.79%   80.02%   +0.22%     
==========================================
  Files          69       69              
  Lines        2529     2548      +19     
==========================================
+ Hits         2018     2039      +21     
+ Misses        511      509       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@s3rius s3rius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request looks good, however, can you please fix tests and simplify parse_acknowledge_type function?

Comment thread taskiq/acks.py Outdated
@vvanglro vvanglro force-pushed the feature/per-task-ack-type branch from 44076b7 to 2bdde8f Compare July 8, 2026 07:28
@s3rius

s3rius commented Jul 8, 2026

Copy link
Copy Markdown
Member

All looks good. Thanks for contributions!

@s3rius s3rius merged commit fe92683 into taskiq-python:master Jul 8, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants