Add per-task ack type support#636
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 79.79% 80.02% +0.22%
==========================================
Files 69 69
Lines 2529 2548 +19
==========================================
+ Hits 2018 2039 +21
+ Misses 511 509 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
s3rius
requested changes
Jul 8, 2026
44076b7 to
2bdde8f
Compare
s3rius
approved these changes
Jul 8, 2026
Member
|
All looks good. Thanks for contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ack_typesupport via task labels, overriding worker-level--ack-typewhen present.AcknowledgeTypeenum values for task-level ack configuration.AcknowledgeTypefromtaskiqand document the new per-task usage.Related discussion: https://github.com/orgs/taskiq-python/discussions/635
Testing
uv run pytest tests/receiver/test_receiver.py -quv run ruff check taskiq/acks.py taskiq/receiver/receiver.py taskiq/__init__.py tests/receiver/test_receiver.pyuv run mypy taskiquv run pytest -q -x --ignore=tests/opentelemetryuv run pytest tests/opentelemetry -q