Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3278 +/- ##
==========================================
- Coverage 98.09% 97.96% -0.14%
==========================================
Files 22 22
Lines 10457 10472 +15
Branches 1808 1810 +2
==========================================
+ Hits 10258 10259 +1
- Misses 182 195 +13
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fabon-f
reviewed
Feb 19, 2026
7149c47 to
12b967f
Compare
Thanks to @fabon-f for the catch!
5d94084 to
aa7bb6d
Compare
ptomato
approved these changes
Feb 19, 2026
Collaborator
ptomato
left a comment
There was a problem hiding this comment.
Great, thanks for digging into this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3158.
When Feb 17 of the ISO year falls in Chinese month
1bis(a leap month after month 1) or month2,getMonthList()crashes because it assumes Feb 17 is either in month1or in the previous year's final month.The fix checks for
2first (backing up into month 1 or theoretically1bis), then for1bis(backing up to the previous year's last month), letting the existing!== '1'logic advance forward into month 1 as expected.Known affected years: 7253 (
1bis), 7625 (2). Thanks to @fabon-f for digging into this!