Polyfill: Fix precision loss rounding large durations to days#3280
Open
jessealama wants to merge 1 commit intotc39:mainfrom
Open
Polyfill: Fix precision loss rounding large durations to days#3280jessealama wants to merge 1 commit intotc39:mainfrom
jessealama wants to merge 1 commit intotc39:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3280 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 22 22
Lines 10457 10458 +1
Branches 1808 1808
=======================================
+ Hits 10258 10259 +1
Misses 182 182
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use bigInt-backed rounding for the smallestUnit === 'day' path, matching how other time units are already handled.
jessealama
force-pushed
the
fix-duration-day-rounding-precision
branch
from
6cfdd51 to
eae2c0f
Compare
Collaborator
|
Not going to get to this today, unfortunately — I need a bit more time to understand it. I'll try to take another look tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3259.
Adds defensiveness for handling non-integer numbers of days by using bigInt-backed rounding for the
smallestUnit === 'day'path, matching how other time units are already handled. Other time units don't appear to be affected.