50 fix projection and 49 update documentation #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traceybit
reviewed
Jun 30, 2025
Collaborator
traceybit
left a comment
traceybit
left a comment
There was a problem hiding this comment.
@tliddell4 these changes look good to me! i left one comment for you to look at, but i don't think it's critical.
R/secondary_weights.R
Outdated
|
|
||
| message(crayon::red("Warning: reprojecting secondary_raster to match grid, which may affect data")) | ||
| secondary_raster <- terra::project(secondary_raster, clim_raster) | ||
| terra::crs(secondary_raster) <- terra::crs(clim_raster, TRUE) |
Collaborator
There was a problem hiding this comment.
i think that terra::project() should automatically change the label (this seemed to happen when i tested the code), but i don't think it would lead to any errors? maybe unless the label was incorrect from the beginning?
Collaborator
Author
There was a problem hiding this comment.
I believe you are correct - I've removed the crs line and pushed the change.
Collaborator
|
merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 49 Documentation updates:
Issue 50 Fix Projection in Secondary Weights