Skip to content

change links checked output from !quiet to verbose#438

Open
jsoref wants to merge 1 commit into
tcort:masterfrom
jsoref:issue-395
Open

change links checked output from !quiet to verbose#438
jsoref wants to merge 1 commit into
tcort:masterfrom
jsoref:issue-395

Conversation

@jsoref

@jsoref jsoref commented Apr 8, 2025

Copy link
Copy Markdown

This doesn't technically remove the line. It just changes the guard from !quiet to verbose. I'm also willing to remove it entirely, but as there is a verbose flag, it seemed somewhat worthwhile to honor that instead of just removing the output entirely.

@BaseMax

BaseMax commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

Hi greetings from Belgium, Need to check more deeply. I am on trip now - in Belgium.

Need to check to make sure logic is right.

What is opts.verbose value? what about opts.quiet?

@jsoref

jsoref commented Apr 8, 2025

Copy link
Copy Markdown
Author

They both appear to be bool-ish values:

if (opts.verbose) {
if (result.err) {
console.log(
" [%s] %s → Status: %s %s",
statusLabels[result.status],
result.link,
result.statusCode,
result.err
);
} else {
console.log(" [%s] %s → Status: %s", statusLabels[result.status], result.link, result.statusCode);
}
} else if (!opts.quiet) {
console.log(" [%s] %s", statusLabels[result.status], result.link);
}

@github-actions

github-actions Bot commented Jun 8, 2025

Copy link
Copy Markdown

This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 30 days unless the stale label is removed or someone adds a comment.

@github-actions github-actions Bot added the Stale label Jun 8, 2025
@jsoref

jsoref commented Jun 8, 2025

Copy link
Copy Markdown
Author

@BaseMax how was Belgium?

@github-actions github-actions Bot removed the Stale label Jun 9, 2025
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown

This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 90 days unless the stale label is removed or someone adds a comment.

@github-actions github-actions Bot added the Stale label Sep 8, 2025
@jsoref

jsoref commented Sep 17, 2025

Copy link
Copy Markdown
Author

@tcort @WillGibson @BaseMax ?

(I'm back from Greece and trying to clean up things...)

@github-actions github-actions Bot removed the Stale label Sep 18, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 90 days unless the stale label is removed or someone adds a comment.

@github-actions github-actions Bot added the Stale label Dec 17, 2025
@jsoref

jsoref commented Dec 17, 2025

Copy link
Copy Markdown
Author

@BaseMax ??

@github-actions github-actions Bot removed the Stale label Dec 18, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 90 days unless the stale label is removed or someone adds a comment.

@github-actions github-actions Bot added the Stale label Mar 18, 2026
@jsoref

jsoref commented Mar 18, 2026

Copy link
Copy Markdown
Author

@BaseMax ?

@github-actions github-actions Bot removed the Stale label Mar 19, 2026
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 90 days unless the stale label is removed or someone adds a comment.

@github-actions github-actions Bot added the Stale label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the per file link check total

2 participants