Skip to content

[Fix/service/#60] Image 태그 수정 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gudusol merged 4 commits into from
Mar 30, 2025
Merged

[Fix/service/#60] Image 태그 수정 #61

gudusol merged 4 commits into from
Mar 30, 2025

Conversation

@gudusol
Copy link
Contributor

@gudusol gudusol commented Mar 30, 2025

📌 Related Issue Number

Checklist

  • 🎋 base 브랜치를 제대로 설정했나요?
  • 🖌️ PR 제목은 형식에 맞게 잘 작성했나요?
  • 🏗️ 빌드는 성공했나요? (pnpm build)
  • 🧹 불필요한 코드는 제거했나요? e.g. console.log
  • 🙇‍♂️ 리뷰어를 지정했나요?
  • 🏷️ 라벨은 등록했나요?

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. img 태그 -> Image 태그로 수정
  2. ImageContainer 수정
  3. 데이터가 로딩되기전에 Image 태그의 src에 ''이 넘어가는게 문제가 돼서, isLoading도 몇개 추가해줌

💡 New Insights & Learnings

  • NEXT의 Image 태그는 width, height가 필수값인데, 이미지가 로드되기전 영역잡는 용으로 쓰이지, 실제 이미지의 크기는 css등으로 결정된다고 함

공식문서 참고

@gudusol gudusol added ✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링 🐽 태승 labels Mar 30, 2025
@gudusol gudusol self-assigned this Mar 30, 2025
@gudusol gudusol merged commit 74c5bfb into main Mar 30, 2025
1 check passed
@gudusol gudusol deleted the fix/service/img-tag-#60 branch March 30, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gudusol gudusol

Labels

✨ Feature 기능 개발 🐽 태승 🔨 Refactor 코드 리팩토링

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feat] img 태그 리팩토링

2 participants

@gudusol