Fix ArgumentError when Rails.logger is wrapped by SemanticLogger#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OS (or any app) wraps
Rails.loggerwith SemanticLogger,logger.levelreturns a symbol (e.g.:info,:debug) instead of the standard RubyLoggerinteger constants. The override-warning logic inDeclarativeInitialization::Internal#warn_override?was doinglogger.level <= Logger::DEBUG, which raisedArgumentError: comparison of Symbol with 0 failedin production.Change: Only compare
logger.leveltoLogger::DEBUGwhenlevelis an integer. If the logger uses a non-integer level (e.g. SemanticLogger), skip the level check and do not warn—so behavior in Rails dev/test is unchanged, standard Logger behavior is unchanged, and SemanticLogger (and similar) no longer raise.Bump to 0.2.1 with changelog entry.