-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT/#382] FCM 푸시알림 커스텀 / Payload 형식에 맞게 구현 #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
boiledeggg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로직이 상당히 복잡하네요😵 4차 스프린트 동안 너무 고생많았어유~~!!
| return appProcesses?.any { | ||
| it.importance == ActivityManager.RunningAppProcessInfo.IMPORTANCE_FOREGROUND && | ||
| it.processName == packageName | ||
| } == true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조건들을 변수로 선언해두면 코드 가독성이 지금보다 좋아질 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다! 가독성이 좋아진 것 같네요:)
| val systemUiController = rememberSystemUiController() | ||
|
|
||
| LaunchedEffect(Unit) { | ||
| systemUiController.setStatusBarColor(color = White) | ||
| systemUiController.setNavigationBarColor(color = White) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이걸 모든 화면에 선언해준 이유는 뭔가요? 안드로이드 API 때문인가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect하면 splash를 거치지 않고 바로 진입하는건가요?!?? splash 통해서 이동하는 로직이면 onDispose 내부에서 white로 다시 바꿔줘도 되지 않을까 싶어서요!(테스트는 안해봐서 될지는 모르겠어잉ㅎㅎ)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 왜 그 생각을 못했을까요!! 잘 됩니당~! 좋은 의견 감사해요!🚀🚀
보충 설명하자면 redirect는 Splash를 거친 후 리다이렉트 할 화면을 의미합니다!
| navOptions = NavOptions.Builder().setPopUpTo( | ||
| route = Splash(redirect), | ||
| inclusive = true | ||
| ).build() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리다이렉트 관련된 화면들의 navOption들이 전부 동일한 것 같은데 하나로 통일해버리는건 어떤가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하나로 통일한다는 건 확장함수로 만들어서 적용하는 걸 의미하는 걸까요..?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
각각 다른 객체를 만들어 넘겨줄 필요 없이 변수 하나 만들어두고 사용하면 되지 않을까 싶어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이해했습니다!! 반영했어요! 역시 가독성의 신 석준오빠..🚀🚀
Hyobeen-Park
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
으아 진짜 어렵네요.. 우리 리드 짱이다 멋있다 최고다🚀🚀
| val systemUiController = rememberSystemUiController() | ||
|
|
||
| LaunchedEffect(Unit) { | ||
| systemUiController.setStatusBarColor(color = White) | ||
| systemUiController.setNavigationBarColor(color = White) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect하면 splash를 거치지 않고 바로 진입하는건가요?!?? splash 통해서 이동하는 로직이면 onDispose 내부에서 white로 다시 바꿔줘도 되지 않을까 싶어서요!(테스트는 안해봐서 될지는 모르겠어잉ㅎㅎ)

⛳️ Work Description
📸 Screenshot
(탐색으로 가는 알림)(홈으로 가는 알림)Screen_Recording_20250429_014720_One.UI.Home.mp4
Screen_Recording_20250429_014938_One.UI.Home.mp4
📢 To Reviewers
startDestination)을 매번 바꾸는 방향으로 수정했습니다! (아린언니 보고 참고해주세요!)업데이트 확인하기(포그라운드): 알림 자체를 처음 눌렀을 때는 스플래쉬를 거치기 때문에, 굳이 사용자가 앱을 쓰고 있을 때 업데이트가 일어나는 경우는 고려할 필요가 없다고 판단.토큰 유무 확인하기: 알림을 받기 위해서는 alarmAvailable을 설정해줘야하는데, 로그인이 안 된 상태는 무조건 alarmAvailable이 false임. 그래서 알림을 받을 케이스가 없음