[♻️ refactor] UserName 검증 개선 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseException과 Exception 처리만으로 충분하므로, UnsupportedOperationException, HttpMediaTypeNotSupportedException, SocketTimeoutException에 대한 별도 핸들러를 제거함.
- INVALID_USER_NAME 메시지에 공백 허용 여부를 명확히 표현
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the user name validation logic and improves error messaging, along with cleaning up unused exception handlers.
- Renamed the null validation method from validateNull to validateNotNull and reordered validation steps.
- Updated the error message for invalid user name format to include the allowance of whitespace.
- Removed redundant exception handler methods from the global exception handler file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/org/terning/user/domain/vo/UserName.java | Renamed the null check method to validateNotNull and reordered validation calls. |
| src/main/java/org/terning/user/common/failure/UserErrorCode.java | Updated the error message to clearly indicate allowed characters (including whitespace). |
| src/main/java/org/terning/global/failure/GlobalExceptionHandler.java | Removed unused exception handlers for unsupported operations, media type, and socket timeout. |
junggyo1020
approved these changes
Mar 27, 2025
| USER_NAME_NOT_NULL(HttpStatus.BAD_REQUEST, "이름은 null일 수 없습니다."), | ||
| USER_NAME_LENGTH_EXCEEDED(HttpStatus.BAD_REQUEST, "이름은 공백 포함 12글자를 넘을 수 없습니다."), | ||
| INVALID_USER_NAME(HttpStatus.BAD_REQUEST, "이름의 구성은 문자(한글, 영어), 숫자만 가능합니다."), | ||
| INVALID_USER_NAME(HttpStatus.BAD_REQUEST, "이름은 한글, 영어, 숫자, 공백으로만 구성할 수 있습니다."), |
Contributor
There was a problem hiding this comment.
공백이 추가되었네요!!! 확실하게 의미를 전달할 수 있는 것 같아 좋은 것 같아요!
Member
Author
There was a problem hiding this comment.
피드백 반영하여 공백을 포함한 조건으로 수정하였습니다! 덕분에 의미를 더 명확하게 전달할 수 있게 된 것 같아요.
감사합니다 😊
Comment on lines
+34
to
35
| validateNotNull(value); | ||
| validateInvalidCharacters(value); |
Contributor
There was a problem hiding this comment.
디테일한 네이밍 센스... 너무 좋습니다
Member
Author
There was a problem hiding this comment.
피드백 덕분에 네이밍에도 더 신경 쓸 수 있었던 것 같아요!
감사합니다 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Work Description
UserNameVO에서 null 검증 메서드 이름을validateNull→validateNotNull로 변경하여 메서드 역할을 명확히 했습니다.UserErrorCode의 에러 메시지를 상황에 맞게 개선했습니다.💬 To Reviewers
📷 Screenshot
⚙️ ISSUE
✅ PR check list