Add PolicyId output to Get-TeamViewerGroup function#102
Conversation
AchilleasMitos-TV
left a comment
AchilleasMitos-TV
left a comment
There was a problem hiding this comment.
Please also bump the minor version of the TeamViewerPS.psd1 as well as add an entry to the CHANGELOG for it.
| else { | ||
| Write-Output ($response.groups | ConvertTo-TeamViewerGroup) | ||
| $groups = @($response.groups | ConvertTo-TeamViewerGroup) | ||
| $groups | ForEach-Object { $_.PSObject.Properties.Remove('PolicyId') } |
There was a problem hiding this comment.
question: why don't we want the PolicyId field when requesting multiple groups?
There was a problem hiding this comment.
Well yes, this is very individual. Personally, I don't need this information in the all group output.
If you say you want it, I can remove my filter again.
I just wanted to keep the "general" output streamlined.
There was a problem hiding this comment.
Since the WebApi endpoint exposes it, I don't see a reason for not including it in the Powershell's response :)
AchilleasMitos-TV
left a comment
AchilleasMitos-TV
left a comment
There was a problem hiding this comment.
Thank you for the improvement on the Cmdlet!
| else { | ||
| Write-Output ($response.groups | ConvertTo-TeamViewerGroup) | ||
| $groups = @($response.groups | ConvertTo-TeamViewerGroup) | ||
| $groups | ForEach-Object { $_.PSObject.Properties.Remove('PolicyId') } |
There was a problem hiding this comment.
Since the WebApi endpoint exposes it, I don't see a reason for not including it in the Powershell's response :)
|
I've incorporated all of your feedback in my last comit. Now it should be ready to merge. For the release process: Should I open an issue to request a release, or should I reach out to @ChristianJ-TV or @stefanhubertus directly (e.g. via E-Mail)? A contribution guide covering this would be helpful! Thanks for the review! |
|
@fs1n an email would do just fine :) As a last thing, please also make sure to clean up the git history appropriately. |
fs1n
force-pushed
the
feature/OutputPolicyIDforGroup
branch
from
ea64b3a to
68e1bc5
Compare
|
Done. |
2 participants
Summary
This PR adds the
PolicyIdfield to the output of theGet-TeamViewerGroupfunction. This enhancement enables retreival of the PolicyID, assigned to a group via theGet-TeamViewerGroup -Id <groupID>cmdlet.Changes
PolicyIdfield toGet-TeamViewerGroupcmdlet outputConvertTo-TeamViewerGroupconversion function to support the new fieldMotivation & Context
Being able to set an Policy to a group, I thought, "Why can't I retrieve it via the PowerShell module?" In a script that I had built, I had to use Invoke-RestMethod in the middle of the script, which is a bit of a maintenance pain. So I updated the module to make this output available too.
Checklist