Skip to content

exclude None-objects from parenting logic #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jerakin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

exclude None-objects from parenting logic #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bqt/blender_applications/blender_application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ def on_update(self) -> None:
bqt.manager._blender_window_change(self._active_window_hwnd)

if os.getenv("BQT_AUTO_ADD", "1") == "1":
bqt.manager.parent_orphan_widgets(exclude=[self.blender_widget, self._blender_window, self.window_container]) # auto parent any orphaned widgets
excluded_objects = [self.blender_widget, self._blender_window, self.window_container]
bqt.manager.parent_orphan_widgets(exclude=[obj for obj in excluded_objects if obj]) # auto parent any orphaned widgets

def blender_focus_toggled(self) -> bool:
"""returns true the first frame the blender window is focussed or unfoccused"""
Expand Down
6 changes: 3 additions & 3 deletions bqt/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
logger = logging.getLogger("bqt")

__widgets: list[WidgetData] = []
__excluded_widgets: WeakSet[QWindow | QWidget | None] = WeakSet()
__excluded_widgets: WeakSet[QWindow | QWidget] = WeakSet()


class WidgetData:
Expand Down Expand Up @@ -62,7 +62,7 @@ def make_widget_dockable(widget) -> QWidget:

def register(
widget: QWidget,
exclude: list[QWindow | QWidget | None] | None = None,
exclude: list[QWindow | QWidget] | None = None,
parent: bool = True,
manage: bool = True,
unique: bool = True
Expand Down Expand Up @@ -191,7 +191,7 @@ def _orphan_toplevel_widgets() -> list[QWidget]:
and widget not in __excluded_widgets]


def parent_orphan_widgets(exclude: list[QWindow | QWidget | None] | None = None) -> None:
def parent_orphan_widgets(exclude: list[QWindow | QWidget] | None = None) -> None:
"""Find and parent orphan widgets to the blender widget"""
# this runs every frame, don't print or log in this method
exclude = exclude or []
Expand Down