Skip to content

PAC-950 Add compatibility with PHP 8.4 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svizevv merged 2 commits into from
Oct 24, 2025
Merged

PAC-950 Add compatibility with PHP 8.4 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92a7227
PAC-950 Add compatibility with PHP 8.4
svizevv Sep 18, 2025
05c77c2
PAC-950 Update dependencies
svizevv Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Version 18.1.0

## Features

### PHP 8.4 Compatibility

* Add PHP 8.4 support

# Version 18.0.0

## Features
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "MIT",
"require": {
"php": "^8.1",
"techdivision/import-attribute": "^23.0.0"
"techdivision/import-attribute": "^23.1"
},
"require-dev": {
"doctrine/dbal": "^4.0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/Observers/AbstractAttributeSetObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ abstract class AbstractAttributeSetObserver extends AbstractObserver
* @param \TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface $attributeSetBunchProcessor The attribute set bunch processor instance
* @param \TechDivision\Import\Observers\StateDetectorInterface|null $stateDetector The state detector instance to use
*/
public function __construct(AttributeSetBunchProcessorInterface $attributeSetBunchProcessor, StateDetectorInterface $stateDetector = null)
public function __construct(AttributeSetBunchProcessorInterface $attributeSetBunchProcessor, ?StateDetectorInterface $stateDetector = null)
{

// set the attribute set bunch processor instance
Expand Down
6 changes: 3 additions & 3 deletions src/Observers/AttributeGroupObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ class AttributeGroupObserver extends AbstractAttributeSetObserver implements Dyn
*/
public function __construct(
AttributeSetBunchProcessorInterface $attributeSetBunchProcessor,
AttributeLoaderInterface $attributeLoader = null,
EntityMergerInterface $entityMerger = null,
StateDetectorInterface $stateDetector = null
?AttributeLoaderInterface $attributeLoader = null,
?EntityMergerInterface $entityMerger = null,
?StateDetectorInterface $stateDetector = null
) {

// set the attribute loader
Expand Down
6 changes: 3 additions & 3 deletions src/Observers/AttributeSetObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ class AttributeSetObserver extends AbstractAttributeSetObserver implements Dynam
*/
public function __construct(
AttributeSetBunchProcessorInterface $attributeSetBunchProcessor,
AttributeLoaderInterface $attributeLoader = null,
EntityMergerInterface $entityMerger = null,
StateDetectorInterface $stateDetector = null
?AttributeLoaderInterface $attributeLoader = null,
?EntityMergerInterface $entityMerger = null,
?StateDetectorInterface $stateDetector = null
) {

// set the attribute loader
Expand Down
Loading