Skip to content

RedisTest throws \RedisException, so expect that, not Warning #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tedivm merged 1 commit into from
Feb 8, 2025
Merged

RedisTest throws \RedisException, so expect that, not Warning #432

tedivm merged 1 commit into from
Feb 8, 2025

Conversation

@DavidGoodwin
Copy link
Contributor

@DavidGoodwin DavidGoodwin commented Jan 29, 2025

RedisTest errors with :

1) Stash\Test\Driver\RedisTest::testBadDisconnect
PHPUnit\Framework\Exception: Class "Warning" does not exist

Caused by
ReflectionException: Class "Warning" does not exist

Fix by changing class to be RedisException which does seem to be thrown.

@DavidGoodwin DavidGoodwin changed the title test throws \RedisException, so expect that, not Warning RedisTest throws \RedisException, so expect that, not Warning Jan 29, 2025
@tedivm tedivm merged commit 2e1954b into tedious:main Feb 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tedivm tedivm tedivm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DavidGoodwin @tedivm