Guest fact discovery via a single script #4438
Open
+421
−392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
step | provision
Contributor
Author
|
Blocked on #4443 |
happz
force-pushed
the
guest-facts-discovery-single-script
branch
from
518614c to
4bde734
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
TL;DR: guest fact discovery now runs as a single remote command, whose output is then parsed into values of individual facts. * Each fact attribute is now defined with a descriptor (see [1]). It keeps the proper type annotation, but we can attach more information. * Each probe is now a shell script snippet, and is attached to its owning fact. * Snippets are collected, joined, and the resulting script is executed. `GuestFacts` then processes the output, delivers discovered values to the right attributes. * No Python code in probes, custom Python code to handle decoding of the script output fully supported (and used, see package manager facts). For the tmt code, nothing changes, `GuestFacts` API remains the same. [1] https://docs.python.org/3/howto/descriptor.html
happz
force-pushed
the
guest-facts-discovery-single-script
branch
from
4bde734 to
51f8a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: guest fact discovery now runs as a single remote command, whose
output is then parsed into values of individual facts.
keeps the proper type annotation, but we can attach more information.
owning fact.
GuestFactsthen processes the output, delivers discovered values tothe right attributes.
script output fully supported (and used, see package manager facts).
For the tmt code, nothing changes,
GuestFactsAPI remains the same.[1] https://docs.python.org/3/howto/descriptor.html
Pull Request Checklist