fix: independant HTML implementation#194
Open
afu-dev wants to merge 6 commits intotempestphp:mainfrom
Open
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit bdf23d8 |
Pull Request Test Coverage Report for Build 21951412065Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs with the XML implementation, regarding tags and attributes. It also add an independant interpreter for the HTML implementation.
Here's a before/after:
XML
Note: tags, XML or HTML, cannot start with a digit or an hyphen.
HTML
Notes:
Current known bugs / regressions
Note: boolean attributes don't work (cannot work?) with the current regex implementation. Also if the string value contains an equal sign, the word before get highlighted (thanks to unquoted attributes).