Closed
Conversation
Member
|
I personally don't like that it takes an entire sidebar section. I am also not sure we want to manually update the docs every time something changes—we discussed internally that we want autogenerated docs, for the string/array utils as well Maybe we can have these docs pages but hide them from the sidebar though, in the meantime |
Member
|
I appreciate the effort! I don't think this is the way to go though because of the updates Enzo mentioned, but also because we're not 100% sure the generated text is correct without manually reviewing it. If we need to do that, we might as well generate the documentation from our documented code — which we already reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the magic of the Google Gemini CLI code generator, I have created documentation for the validation rules in located in the
Tempest\Validation\Rules-namespace. Each rule document has the following sections:I have placed the rules in a new section called
Validation Rules, the first article contains an overview with some generic information. Next section contains links to the the rules organized per category.Open questions:
Please let me know if you have any questions!
Fixes: tempestphp/tempest-framework#1034