Skip to content

chore: add mdx style comment matches #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lennessyy merged 2 commits into from
Sep 29, 2025
Merged

chore: add mdx style comment matches #91

lennessyy merged 2 commits into from
Sep 29, 2025

Conversation

@lennessyy
Copy link
Contributor

@lennessyy lennessyy commented Sep 19, 2025 •
edited
Loading

This PR:

  • Adds matching for MDX style comments. Also added guardrails for mixing the two style of tags.
  • Increments the package version so we can publish it on npm later
  • Adds a .gitattribute file to avoid line ending issues, which both Milecia and I ran into earlier.

@lennessyy lennessyy requested a review from axfelix September 19, 2025 17:21
axfelix
axfelix approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@axfelix axfelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and thanks for doing the version bump! This is probably ready for a release.

@lennessyy lennessyy merged commit c98a545 into main Sep 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@axfelix axfelix axfelix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lennessyy @axfelix