Evolve documentation of update polling parameters#406
Open
dandavison wants to merge 2 commits intotemporalio:masterfrom
Open
Evolve documentation of update polling parameters#406dandavison wants to merge 2 commits intotemporalio:masterfrom
dandavison wants to merge 2 commits intotemporalio:masterfrom
Conversation
cretz
approved these changes
May 20, 2024
cretz
approved these changes
May 20, 2024
dandavison
force-pushed
the
update-polling-edits
branch
from
a732611 to
ccb8b29
Compare
yiminc
reviewed
May 20, 2024
Sushisource
approved these changes
May 20, 2024
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
It would be cool if you could update the variants in the enum too to specify what they mean as a request (already exists) and what they mean as a return value (which I don't think they say, and would be nice to have).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.