Draft
Conversation
bergundy
commented
May 8, 2025
| Sync sync_success = 1; | ||
| Async async_success = 2; | ||
| // The operation completed unsuccessfully (failed or canceled). | ||
| temporal.api.nexus.v1.UnsuccessfulOperationError operation_error = 3; |
Member
Author
There was a problem hiding this comment.
Note that HandlerError is not represented here or in any of the other responses. The idea is that HandlerError would be a new serviceerror but I am on the fence here, we may want to include the handler errors directly in the response.
bergundy
commented
May 8, 2025
Comment on lines
+2305
to
+2306
| // Request headers to forward to the Handler. | ||
| map<string, string> header = 4; |
Member
Author
There was a problem hiding this comment.
Alternatively, we may want headers to be grpc metadata. Trying to figure out what would be better here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
To allow non-workflow Nexus calls.
Server PR
Not yet, this is just a draft for initial discussion.
Some points for discussion: