standalone activity: add activity_ prefix to id_reuse/conflict_policy#707
Closed
yuandrew wants to merge 1 commit intotemporalio:masterfrom
Closed
standalone activity: add activity_ prefix to id_reuse/conflict_policy#707yuandrew wants to merge 1 commit intotemporalio:masterfrom
yuandrew wants to merge 1 commit intotemporalio:masterfrom
Conversation
Closed
5 tasks
bergundy
approved these changes
Jan 29, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
This is going to be painful to change because it breaks compilation of the SDK. I would be fine with the change but don't think it's necessarily worth it.
cretz
approved these changes
Jan 29, 2026
Contributor
Author
|
Ehh, scrapping this effort, not worth the effort to coordinate the change across server/SDKs.. we can live with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
activity_prefix toid_reuse_policyandid_conflict_policyWhy?
to match the existing
workflow_id_reuse_policyandworkflow_id_conflict_policyBreaking changes
Breaking change for a feature not yet released
Server PR
temporalio/temporal#9170