Update pydantic samples to use contrib module#163
Conversation
There was a problem hiding this comment.
Would prefer a pydantic_converter_v1 sample instead of putting inside another sample
There was a problem hiding this comment.
v1's a thing of the past. I think that pollutes the top-level namespace unnecessarily.
There was a problem hiding this comment.
I think it's easier to ignore a top-level sample you don't care about than code inside a sample you do. This looks like v1 is a subdir/module of the pydantic_converter sample, not its own sample. Subdirs of Python code are usually considered modules of that code, not separate/unrelated (and this has been the case in samples thus far).
There was a problem hiding this comment.
OK you're probably right about the structure. But let's delete it at some point -- when we do we can always leave a permalink to the content in git history in the remaining README of the v2 sample.
This reverts commit 67e20be.
There was a problem hiding this comment.
Would move this to tests/pydantic_converter_v1 dir
To merge once temporalio/sdk-python#757 is released