Draft
Conversation
cretz
reviewed
Jul 10, 2025
| set_open_ai_agent_temporal_overrides, | ||
| ) | ||
| from temporalio.contrib.openai_agents import Plugin | ||
| from temporalio.contrib.pydantic import pydantic_data_converter |
Member
There was a problem hiding this comment.
This import not needed anymore either
Contributor
There was a problem hiding this comment.
[I like using a ruff IDE extension and setting format-on-save to true.]
dandavison
reviewed
Jul 15, 2025
| client = await Client.connect( | ||
| "localhost:7233", | ||
| data_converter=open_ai_data_converter, | ||
| plugins=[Plugin()], |
Contributor
There was a problem hiding this comment.
I think we probably want to encourage plugin authors to name this object like OpenAIAgentsPlugin so that even if imported using from ... import ... it's still clear at the usage site what plugin it is.
Alternatively we could reference it as openai_agents.Plugin, but I think encouraging the fully-qualified plugin object name makes sense.
| set_open_ai_agent_temporal_overrides, | ||
| ) | ||
| from temporalio.contrib.openai_agents import Plugin | ||
| from temporalio.contrib.pydantic import pydantic_data_converter |
Contributor
There was a problem hiding this comment.
[I like using a ruff IDE extension and setting format-on-save to true.]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: