Draft
Conversation
git rm -rf crates/common/protos/api_upstream && \
git commit -m "Remove api_upstream for subtree re-add" && \
git subtree add --prefix=crates/common/protos/api_upstream --squash ssh://git@github.com/temporalio/api.git standalone-activity-on-sdk-core
git reset --soft 12bc359
git commit -m "Update api subtree from standalone-activity"
But then reverted two things that were incorrectly deleted.
I guess standalone-activity-on-sdk-core was not actually forked off
the api commit that sdk-core was using. This would be easier if
sdk-core used a submodule instead of a subtree.
dandavison
force-pushed
the
standalone-activity
branch
from
52d6adc to
924a0b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See temporalio/sdk-python#1138
This is currently rebased on the commit that
sdk-pythonwas using; it needs to be rebased onsdk-coremaster.