-
Notifications
You must be signed in to change notification settings - Fork 157
Experimental: External Payload Storage #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmaeagle99
wants to merge
12
commits into
temporalio:main
Choose a base branch
from
jmaeagle99:extstore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
71cff0d
External payload storage
jmaeagle99 086640b
Remove external converter in favor of payload codec
jmaeagle99 8c7b418
Replace DriverError and DriverNotFoundError with RuntimeError
jmaeagle99 e4883d1
Import exstore module instead of types
jmaeagle99 c39be13
Remove DriverSelector
jmaeagle99 354888e
Remove PayloadNotFoundError in favor of non-retryable ApplicationError
jmaeagle99 9da8504
Renames and doc updates
jmaeagle99 cab33e2
Remove unused import
jmaeagle99 3fffe91
Formatting
jmaeagle99 734088a
Undo breaking changes
jmaeagle99 a0ddf52
Rename field
jmaeagle99 89ac04f
Use mapping instead of dict
jmaeagle99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you are hitting a bug, I'd be ok just importing this regardless of whether type checking (even if at the moment it is only for type checking)