This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Open
Conversation
* refactor: add new flag --tls, to create tls connection by host from the given address * refactor: сhange parsing value of args * refactor: сhange usage * refactor: change the logic. (If we have server name, then it is not need to get tls flag) * refactor: change parsing of TLS flag * refactor: change parsing flag address * refactor: rewrite comment * refactor: rewrite comment
|
|
feedmeapples
approved these changes
May 4, 2023
Author
|
Hi! It's been a while since my request was approved for the merge, but I haven't heard any updates yet on when it will be merged. Is there anything else that needs to be done on my end, or something else that is slowing down the merge process? Let me know if there's anything I can do to help. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
--tlsflag to app.flags slice--tlsflag with checking on error. And added the logic that when the flag is activated, the host is taken from the address/localhost--tlsflag name--tlsflag to app.flags slice--tlsflag with checking on error. And added the logic that when the flag is activated, the host is taken from the address/localhostWhy?
I am connecting to my server over a TLS connection and I had to duplicate my host from the
--addressflag to the--tls_server_nameflag. This cluttered up the command, as well as misleading.Checklist
Closes #146
How was this tested:
Related to same issue
temporalio/cli#210