[Scheduler] CountSchedules implementation for V1 and V2#9046
Merged
lina-temporal merged 8 commits intomainfrom Jan 29, 2026
Merged
[Scheduler] CountSchedules implementation for V1 and V2#9046lina-temporal merged 8 commits intomainfrom
lina-temporal merged 8 commits intomainfrom
Conversation
chaptersix
reviewed
Jan 27, 2026
| func (wh *WorkflowHandler) CountSchedules( | ||
| ctx context.Context, | ||
| request *workflowservice.CountSchedulesRequest, | ||
| ) (_ *workflowservice.CountSchedulesResponse, retError error) { |
Contributor
There was a problem hiding this comment.
What is the purpose of including the underscore here?
Contributor
Author
There was a problem hiding this comment.
It's because you need to name both arguments if you name one of them, and yet I never assign to the first return argument, so instead it is bound to "unused"/_.
chaptersix
reviewed
Jan 27, 2026
chaptersix
reviewed
Jan 27, 2026
service/frontend/workflow_handler.go
Outdated
Comment on lines
4612
to
4615
| if wh.chasmSchedulerEnabled(ctx, namespaceName.String()) { | ||
| return wh.countSchedulesChasm(ctx, namespaceID, namespaceName, query) | ||
| } | ||
| return wh.countSchedulesWorkflow(ctx, namespaceID, namespaceName, query) |
Contributor
There was a problem hiding this comment.
We are doing a pretty gradual rollout so there might be a significant amount of time where there is schedulers leftover on v1 stack. Once the flag is flipped for the namespace the count drops to 0 and increases as new schedules are created. Some time later, it increases as schedules wake up....
Contributor
Author
There was a problem hiding this comment.
The query itself we select with handles this case - VisibilityListQueryChasm will return results from both V1 and V2 scheduler, that'll apply to Count, as well.
I'll update the ListV1andV2 functional test to show this.
chaptersix
approved these changes
Jan 28, 2026
lina-temporal
added a commit
to temporalio/api
that referenced
this pull request
Jan 28, 2026
**What changed?** - Added a new CountSchedules API, symmetric to the other Count* operations. **Why?** - Although it isn't documented as public API, the temporal UI makes use of `ListWorkflowExecutions` to display the total count of schedules. This operation will not return data for CHASM-based schedules. Therefore, I'm introducing a public CountSchedules operation that the UI (and customers) can make use of. **Breaking changes** - The technique of using `ListWorkflowExecutions` to query schedules was always unsupported, so we aren't interested in supporting it for CHASM schedules. - `CountSchedules` will be implemented for both V1 and V2 schedules. **Server**: - [Server implementation PR](temporalio/temporal#9046)
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Jan 28, 2026
**What changed?** - Added a new CountSchedules API, symmetric to the other Count* operations. **Why?** - Although it isn't documented as public API, the temporal UI makes use of `ListWorkflowExecutions` to display the total count of schedules. This operation will not return data for CHASM-based schedules. Therefore, I'm introducing a public CountSchedules operation that the UI (and customers) can make use of. **Breaking changes** - The technique of using `ListWorkflowExecutions` to query schedules was always unsupported, so we aren't interested in supporting it for CHASM schedules. - `CountSchedules` will be implemented for both V1 and V2 schedules. **Server**: - [Server implementation PR](temporalio/temporal#9046)
The CountSchedules API was added to the workflowservice but was missing from the API metadata map and related test fixtures, causing unit test failures.
Add Eventually helpers around query-filtered CountSchedules assertions to handle potential visibility indexing latency on Cassandra+ES backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
CountSchedulesAPI for both CHASM and V1 scheduler.Why?
ListWorkflowExecutionscall to get a total count of schedules. This will allow us to move it to a public API in advance of CHASM release, which will continue to work for both V1 and V2.How did you test it?
Potential risks