Draft
Conversation
stephanos
force-pushed
the
slim-jobs
branch
2 times, most recently
from
9c9f362 to
07ba05d
Compare
stephanos
commented
Feb 4, 2026
| path: ~/.cache/go-build | ||
| key: go-${{ runner.os }}${{ runner.arch }}-build-${{ env.COMMIT }} | ||
|
|
||
| - name: Run functional test xdc |
Contributor
Author
There was a problem hiding this comment.
merged into functional-test
stephanos
commented
Feb 4, 2026
|
|
||
| # NDC matrix job. Include `${{ matrix.name }}` in the display name so each | ||
| # matrix variant has a unique name for the job-id lookup. | ||
| functional-test-ndc: |
Contributor
Author
There was a problem hiding this comment.
merged into functional-test
stephanos
commented
Feb 4, 2026
|
|
||
| # XDC matrix job. Include `${{ matrix.name }}` in the display name so each | ||
| # matrix variant has a unique name for the job-id lookup. | ||
| functional-test-xdc: |
Contributor
Author
There was a problem hiding this comment.
merged into functional-test
stephanos
force-pushed
the
slim-jobs
branch
3 times, most recently
from
1a5f710 to
ea0720a
Compare
stephanos
commented
Feb 4, 2026
| } | ||
| s.T().Logf("Running %s in test shard %d/%d", s.T().Name(), index+1, total) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
drive-by cleanup: not used!
stephanos
force-pushed
the
slim-jobs
branch
3 times, most recently
from
6bb6773 to
49192f8
Compare
stephanos
commented
Feb 4, 2026
Makefile
Outdated
| FUNCTIONAL_TEST_ROOT := ./tests | ||
| FUNCTIONAL_TEST_XDC_ROOT := ./tests/xdc | ||
| FUNCTIONAL_TEST_NDC_ROOT := ./tests/ndc | ||
| FUNCTIONAL_TEST_ALL_ROOTS := $(FUNCTIONAL_TEST_ROOT) $(FUNCTIONAL_TEST_XDC_ROOT) $(FUNCTIONAL_TEST_NDC_ROOT) |
Contributor
Author
There was a problem hiding this comment.
Running all 3 together now.
stephanos
force-pushed
the
slim-jobs
branch
8 times, most recently
from
44f55e2 to
00a67f3
Compare
stephanos
commented
Feb 5, 2026
| done | ||
| echo "job_matrix=$MATRIX" >> "$GITHUB_OUTPUT" | ||
| echo "Generated $(jq length <<< "$MATRIX") jobs" |
Contributor
Author
There was a problem hiding this comment.
^ I didn't think there's much of a benefit of having this a script.
stephanos
force-pushed
the
slim-jobs
branch
7 times, most recently
from
73bd85a to
0bd6218
Compare
stephanos
force-pushed
the
slim-jobs
branch
3 times, most recently
from
84f7ef3 to
41349da
Compare
stephanos
commented
Feb 5, 2026
| name: Test setup | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| shard_indices: ${{ steps.generate_output.outputs.shard_indices }} |
Contributor
Author
There was a problem hiding this comment.
Some of these are now in compute_matrix
stephanos
force-pushed
the
slim-jobs
branch
6 times, most recently
from
607f6c8 to
43b31f1
Compare
stephanos
commented
Feb 5, 2026
.github/workflows/run-tests.yml
Outdated
| # smoke tests run specific suites via TEST_ARGS | ||
| TEST_TOTAL_SHARDS: ${{ matrix.total_shards || '' }} | ||
| TEST_SHARD_INDEX: ${{ matrix.shard_index || '' }} | ||
| TEMPORAL_TEST_TOTAL_SHARDS: ${{ matrix.total_shards || '' }} |
Contributor
Author
There was a problem hiding this comment.
Using prefix TEMPORAL_ to be consistent with other Temporal env vars.
Contributor
There was a problem hiding this comment.
They were chosen to be consistent with Bazel's test sharding protocol, but we're not using that so 🤷
stephanos
force-pushed
the
slim-jobs
branch
11 times, most recently
from
a2733fd to
5c8ab11
Compare
stephanos
force-pushed
the
slim-jobs
branch
3 times, most recently
from
721d440 to
151e888
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Running an abridged database coverage (unless on main/release branch or touching persistence)
Why?
Reduce PR failure rate by not running tests for every database setup.
Note that an earlier version of this PR also merged
xdcandndcwith the other tests across shards but there were a couple of issues (e.g. xdc and ndc are not shard aware) that we'll address later.How did you test it?