Dispatch CancelActivityNexusTask to worker via Nexus control queue#9233
Open
rkannan82 wants to merge 2 commits intokannan/activity-cancel/task-definitionfrom
Open
Dispatch CancelActivityNexusTask to worker via Nexus control queue#9233rkannan82 wants to merge 2 commits intokannan/activity-cancel/task-definitionfrom
rkannan82 wants to merge 2 commits intokannan/activity-cancel/task-definitionfrom
Conversation
This was referenced Feb 5, 2026
- Add WorkerInstanceKey() and ControlQueueName() to testvars - Auto-populate WorkerInstanceKey in taskpoller - Fix nil Nexus header panic in matching engine - Fix WorkerInstanceKey not forwarded between task queue partitions - Add TestActivityCancelControlTaskDispatch functional test
a91654f to
6a655f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR implements the dispatch logic for CancelActivityNexusTask. When the task is processed, it sends a CancelActivitiesRequest to the worker's Nexus control queue using the existing DispatchNexusTask RPC.
Changes
Task executor: transfer_queue_active_task_executor.go
processCancelActivityNexus: Main handler for the task
getWorkerControlQueueName: Looks up the worker's control queue from the worker registry via DescribeWorker API
dispatchActivityCancelToWorker: Builds task tokens and dispatches via DispatchNexusTask
Checks EnableActivityCancellationNexusTask dynamic config before processing
Returns NotFound error (triggering retry) if worker not found in registry
Control queue naming: Uses workerControlQueuePrefix (/temporal-sys/worker-commands) + worker_grouping_key from worker heartbeat
Batching: Single Nexus operation contains all activity task tokens for a worker
Why?
To support activity cancellation without activity heartbeat.
Overall flow:
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.