Nav update icon projects/kt #3090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KATIETOLER
requested review from
a team,
Alex-Tideman and
rossedfort
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| }: Props = $props(); | ||
| const [x, y] = $derived(point); | ||
Contributor
There was a problem hiding this comment.
⚠️ Type 'SVGTextElement | undefined' is not assignable to type 'SVGTextElement'.
| const showIcon = $derived(icon && config); | ||
| const textWidth = $derived(textElement?.getBBox()?.width || 0); | ||
| const backdropWidth = $derived(showIcon ? textWidth + 36 : textWidth + 12); | ||
| const textX = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ 'config' is possibly 'undefined'.
| const activityTaskScheduled = $derived( | ||
| group.eventList.find(isActivityTaskStartedEvent), | ||
| ); | ||
| const retried = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ 'activityTaskScheduled.attributes.attempt' is possibly 'null' or 'undefined'.
| {#key [namespace]} | ||
| <PaginatedTable | ||
| let:visibleItems | ||
| {onFetch} |
Contributor
There was a problem hiding this comment.
⚠️ Type '(err: APIErrorResponse) => void' is not assignable to type '(error: unknown) => void | undefined'.
| query: string | null, | ||
| onError: ErrorCallback, | ||
| request = fetch, | ||
| ): Promise<PaginatedSchedulesPromise> => { |
Contributor
There was a problem hiding this comment.
⚠️ Type '(pageSize?: number, token?: string) => Promise<{ items: IScheduleListEntry[]; nextPageToken: string; } | { items: IScheduleListEntry[] | null | undefined; nextPageToken: string; }>' is not assignable to type 'PaginatedSchedulesPromise'.
| import { get, type Subscriber } from 'svelte/store'; | ||
|
|
||
| import { startOfDay } from 'date-fns'; | ||
| import { enUS } from 'date-fns/locale'; |
Contributor
There was a problem hiding this comment.
⚠️ Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.
Contributor
|
KATIETOLER
requested review from
GraceGardner and
rossnelson
and removed request for
Alex-Tideman and
rossedfort
| ? 'focus-visible:ring-success' | ||
| : 'focus-visible:ring-primary/70'}" | ||
| onclick={toggle} | ||
| {#if isCloud} |
Collaborator
There was a problem hiding this comment.
We should make this it's own component instead of an if statement. Start with a CloudNavBar and OSSNavBar and if we want to use CloudNavBar for OSS we can switch to that
Contributor
Author
There was a problem hiding this comment.
yess thats a much better plan.
Contributor
Author
|
See this PR -- without all the unintended changes -- here --> #3095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to add the underlying structure for the new nav.
The effect of this PR adds more svelte5 migrations because the nav is central to a lot of things and updating it ended up being more hairy than I had hoped for.
The LLM helped me do this, so there are probably errors or weirdness somewhere I am code blind to.
The application seemed to run fine though, so maybe I am paranoid.
The icons are added and there are lots of guard rails to prevent any of these changes to prod until we are ready.