A backdoor lockpick for Phicomm's routers#11
Open
oblivia-simplex wants to merge 2 commits intotenable:masterfrom
Open
A backdoor lockpick for Phicomm's routers#11oblivia-simplex wants to merge 2 commits intotenable:masterfrom
oblivia-simplex wants to merge 2 commits intotenable:masterfrom
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/ca-key.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/client.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/demoCA/private/cakey.pem | View secret |
| - | DSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/dsa-ca.pem | View secret |
| - | DSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/dsa-pca.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/pca-key.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/privkey.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/rsa8192.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/s1024key.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/s512-key.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/server.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/apps/server2.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/certs/demo/ca-cert.pem | View secret |
| - | DSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/certs/demo/dsa-ca.pem | View secret |
| - | DSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/certs/demo/dsa-pca.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/certs/demo/pca-cert.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/bio/server.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/cms/cakey.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/cms/signer.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/cms/signer2.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/easy_tls/cert.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/privkey.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/sign/key.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/sign/sig.txt | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/smime/cakey.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/smime/signer.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/smime/signer2.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/tunala/A-client.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/demos/tunala/A-server.pem | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/ms/keyCA.ss | View secret |
| - | RSA Private Key | 1e75433 | Phicomm/backdoor-lockpick_tra-2022-01/openssl-1.0.2/ms/keyU.ss | View secret |
🛠 Guidelines to remediate hardcoded secrets
-
Revoke and rotate the secret.
-
If possible, rewrite git history with
git commit --amendandgit push --force.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Author
|
GitGuardian is complaining about some hardcoded pems included in the copy of openssl I've got stuffed in there. Nothing to worry about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committing a PoC for the backdoors discussed here: https://medium.com/tenable-techblog/a-backdoor-lockpick-d847a83f4496
Verified to work on all known models and firmware versions of Phicomm routers (at least those released in the last few years).