Remove Compile Errors on debian #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willow-ahrens
approved these changes
Apr 14, 2025
Contributor
willow-ahrens
left a comment
willow-ahrens
left a comment
There was a problem hiding this comment.
I can confirm that taco fails to build on bookworm, and that these changes allow it to build. I can also confirm that taco fails to build on the MIT commit group cluster environment (the environment on which taco was originally developed). Taco continues to pass tests.
Contributor
|
The jobs are not running because the ubuntu 18.04 runner has been deprecated. I think that should be fixed in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #571
To reproduce, use a debian bookworm docker image.