Validate SimpleVocab special tokens before reading IDs#423
Open
fallintoplace wants to merge 1 commit into
Open
Validate SimpleVocab special tokens before reading IDs#423fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SimpleVocab now validates the selected special-token family before reading any IDs from
token_to_id_. This avoids usingoperator[]during validation, which could insert a missing SOS token with ID 0 and let a malformed vocab load successfully.The loader now also rejects mixed lowercase/uppercase special-token families and duplicate IDs among the required special tokens. The duplicate check is intentionally scoped to SOS/EOS/UNK so existing vocab aliases outside those required tokens are not affected.
Tests
python3 -m py_compile lingvo/core/ops/simple_vocab_test.pygit diff --check -- lingvo/core/ops/simple_vocab.cc lingvo/core/ops/simple_vocab_test.pyUSE_BAZEL_VERSION=5.3.0 npx -y @bazel/bazelisk test --experimental_repo_remote_exec //lingvo/core/ops:simple_vocab_testdid not reach analysis in this checkout because@rules_cc//cc:cc_library.bzlis not declared/resolved by the workspace.