Validate per-host infeed batch scaling#425
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
scale_global_to_infeed()now usesdivmod()when per-host TPU infeed scaling is active and raises if the global batch size cannot be evenly divided by the TPU host count.This matches the stricter behavior already used by
scale_global_to_worker()and avoids silently truncatingglobal_batch_size, for example turning 10 examples over 4 hosts into 8 effective examples.History checked
scale_global_to_infeed()was introduced in1594137c6with floor division. The stricterscale_global_to_worker()precedent was added later in8ce7aa894.Tests
python3 -m py_compile lingvo/core/batch_utils.py lingvo/core/batch_utils_test.pygit diff --check -- lingvo/core/batch_utils.py lingvo/core/batch_utils_test.pyscale_global_to_infeed()divisible and non-divisible casesUSE_BAZEL_VERSION=5.3.0 npx -y @bazel/bazelisk test --experimental_repo_remote_exec //lingvo/core:batch_utils_testdoes not reach analysis in this checkout because@rules_cc//cc:cc_library.bzlis not declared/resolved by the workspace.