Handle sparse BOW token ids#426
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Vocab::GetBowTokenIds()now sizes its result by the largest non-negative token ID rather than by the number of tokens. That keeps sparse explicit vocab IDs from indexing past the end of the returned vector.Vocab::Load()now tracks the largest non-negative ID while loading. It preserves existing support for negative non-BOW token IDs, but rejects negative IDs on BOW-prefixed tokens because those cannot be represented in a vector indexed by token ID.A new C++ regression test covers a sparse BOW token ID at 100, a negative non-BOW ID, and rejection of a negative BOW token ID.
History checked
GetBowTokenIds()was added in9d15517c8usingid_to_token_.size()as the vector size. That assumes dense IDs, whileload_token_ids_from_vocab=Truesupports explicit IDs.Tests
python3 -m py_compile lingvo/core/ops/simple_vocab_test.pygit diff --check -- lingvo/core/ops/simple_vocab.cc lingvo/core/ops/simple_vocab.h lingvo/core/ops/simple_vocab_cc_test.cc lingvo/core/ops/BUILDUSE_BAZEL_VERSION=5.3.0 npx -y @bazel/bazelisk test --experimental_repo_remote_exec //lingvo/core/ops:simple_vocab_cc_testdoes not reach analysis in this checkout because@rules_cc//cc:cc_library.bzlis not declared/resolved by the workspace.USE_BAZEL_VERSION=5.3.0 npx -y @bazel/bazelisk test --experimental_repo_remote_exec //lingvo/core/ops:simple_vocab_testfails at the same workspace loading step.